[virt-tools-list] [virt-viewer 2/5] remote-viewer: Remove unneeded g_application_hold() call

Eduardo Lima (Etrunko) etrunko at redhat.com
Tue Jun 14 21:59:38 UTC 2016


On 06/14/2016 06:40 PM, Fabiano Fidêncio wrote:
> This call was added as hack during the GApplication's port, as the
> remote-viewer window was closed as soon as the connection happened.
> 
> This behaviour hapened because we didn't chain-up to the parent's
> window_added() method, which already calls g_application_hold()..
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  src/virt-viewer-app.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index b99ed32..4c3a373 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -1825,8 +1825,6 @@ virt_viewer_app_on_application_startup(GApplication *app)
>          g_application_quit(app);
>          return;
>      }
> -
> -    g_application_hold(app);
>  }
>  
>  static gboolean
> 

Thanks for finding the real problem here. So, this one could be squashed
with previous one maybe?

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list