[virt-tools-list] [PATCH python v2] Use storage pool lifecycle events

Jovanka Gulicoska jovanka.gulicoska at gmail.com
Thu Jun 16 14:33:22 UTC 2016


It doesn't make a difference. I've missed it.

Thanks,
Jovanka

On Wed, Jun 15, 2016 at 1:24 AM, Cole Robinson <crobinso at redhat.com> wrote:

> On 06/14/2016 05:52 PM, Jovanka Gulicoska wrote:
> > Changes since v1: split long lines, remove unnecessary call of tick(),
> > remove code cleanup
> > ---
> >  virtManager/connection.py  | 37 +++++++++++++++++++++++++++++++++++++
> >  virtManager/storagepool.py |  4 +++-
> >  2 files changed, 40 insertions(+), 1 deletion(-)
>
> >
> > diff --git a/virtManager/storagepool.py b/virtManager/storagepool.py
> > index b099fbe..b39fcfb 100644
> > --- a/virtManager/storagepool.py
> > +++ b/virtManager/storagepool.py
> > @@ -40,7 +40,7 @@ class vmmStorageVolume(vmmLibvirtObject):
> >      ##########################
> >
> >      def _conn_tick_poll_param(self):
> > -        return None
> > +        return "pollpool"
> >      def class_name(self):
> >          return "volume"
> >
>
> This bit is still here, does it actually make any difference? I don't
> think it
> should be required, but I haven't tested
>
> Thanks,
> Cole
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160616/7927e8ce/attachment.htm>


More information about the virt-tools-list mailing list