[virt-tools-list] [virt-viewer v2 1/4] timed-revealer: Fix "revealer" refcounting

Fabiano Fidêncio fidencio at redhat.com
Tue Jun 28 15:22:59 UTC 2016


From: Christophe Fergeau <cfergeau at redhat.com>

virt_viewer_timed_revealer_new calls gtk_container_add on the instance
returned by gtk_revealer_new so VirtViewerTimedRevealer does not own any
ref on this GtkRevealer instance. Unrefing it in _dispose() is thus wrong.
---
 src/virt-viewer-timed-revealer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/virt-viewer-timed-revealer.c b/src/virt-viewer-timed-revealer.c
index 9124dad..cad9ede 100644
--- a/src/virt-viewer-timed-revealer.c
+++ b/src/virt-viewer-timed-revealer.c
@@ -126,7 +126,7 @@ virt_viewer_timed_revealer_dispose(GObject *object)
     VirtViewerTimedRevealerPrivate *priv = self->priv;
 
     g_clear_object(&priv->evBox);
-    g_clear_object(&priv->revealer);
+    priv->revealer = NULL;
 
     if (priv->timeout_id) {
         g_source_remove(priv->timeout_id);
-- 
2.7.4




More information about the virt-tools-list mailing list