[virt-tools-list] [PATCH] timed-revealer: listen to the "grab-notify" signal

Christophe Fergeau cfergeau at redhat.com
Thu Jun 30 09:50:08 UTC 2016


On Wed, Jun 29, 2016 at 04:11:54PM -0300, Eduardo Lima (Etrunko) wrote:
> On 06/29/2016 10:36 AM, Fabiano Fidêncio wrote:
> > The "grab-notify" signal lets us know when our widget becomes
> > shadowed by a Gtk+ grab on another widget, or when it becomes unshadowed
> > due to a grab being removed.
> > 
> > That's exactly the case we face when dealing with "usb-redirection" and
> > "close" items of the fullscreen toolbar. And, currently, when these
> > widgets get closed the timed-revealer stays there forever. From now on
> > let's take advantage of the "grab-notify" signal and schedule a timeout
> > for the revealer when these widgets' windows get closed.
> > 
> 
> 
> Reading the docs about the 'grab-notify' signal, it indeed seems the
> right thing to do (TM), but would be nice to have Christophe opinion
> here too, as he was involved in reviewing the refactor of this widget.

Looks good to me too

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160630/67a90ed9/attachment.sig>


More information about the virt-tools-list mailing list