[virt-tools-list] [virt-viewer v2] ovirt: Only use active ISO domains for foreign menu

Christophe Fergeau cfergeau at redhat.com
Wed Mar 2 07:52:28 UTC 2016


oVirt storage domains can be in various states (inactive, in
maintainance, ...). We only want to show the ISOs it contains in the
foreign menu when the storage domain is actually active, not in the
other states.

https://bugzilla.redhat.com/show_bug.cgi?id=1310450
---
Changes since v1:
     - added new condition to an existing if() block
     - added bug reference

 src/ovirt-foreign-menu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 9859439..13aceba 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -650,9 +650,11 @@ static void storage_domains_fetched_cb(GObject *source_object,
     while (g_hash_table_iter_next(&iter, NULL, (gpointer *)&domain)) {
         OvirtCollection *file_collection;
         int type;
+        int state;
 
-        g_object_get(domain, "type", &type, NULL);
-        if (type != OVIRT_STORAGE_DOMAIN_TYPE_ISO) {
+        g_object_get(domain, "type", &type, "state", &state, NULL);
+        if ((type != OVIRT_STORAGE_DOMAIN_TYPE_ISO)
+                || (state != OVIRT_STORAGE_DOMAIN_STATE_ACTIVE)) {
             continue;
         }
 
-- 
2.5.0




More information about the virt-tools-list mailing list