[virt-tools-list] [PATCH v2 5/5] virt-manager: add opengl graphics option

[Cole Robinson]

On 03/10/2016 12:10 PM, Marc-André Lureau wrote:
> Hi Cole
> 
> ----- Original Message -----
>> On 03/04/2016 06:31 AM, Marc-André Lureau wrote:
>>> From: Marc-André Lureau <marcandre.lureau at gmail.com>
>>>
>>> Add a OpenGl checkbox to the Spice graphics option.
>>>
>>> Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
>>> ---
>>>  ui/gfxdetails.ui          | 29 +++++++++++++++++++++++++++++
>>>  virtManager/details.py    |  9 +++++++--
>>>  virtManager/domain.py     |  5 ++++-
>>>  virtManager/gfxdetails.py | 11 ++++++++---
>>>  4 files changed, 48 insertions(+), 6 deletions(-)
>>
>> I pushed 1-4, thanks!
> 
> thanks! 
> 
>> What does enabling just gl for spice give us, without virtio-gpu + 3daccel?
>> Any error scenarios or weirdness?
> 
> No error, it will just not use it (but it may change in the future).
> 
> regards
> 

Okay, I'd like to hold off a bit on exposing in the UI until I play with it
some... I don't want this ending up in Fedora and people start clicking the
box then complain about nothing happening. So at least disabling it for older
libvirt/qemu versions, and showing a warning box if we know it's not going to
add anything, etc.

Thanks,
Cole