[virt-tools-list] [virt-viewer v2 1/2] Remove nsis installer

Fabiano Fidêncio fidencio at redhat.com
Mon May 2 12:29:22 UTC 2016


On Mon, May 2, 2016 at 11:22 AM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Apr 27, 2016 at 05:53:04PM +0200, Fabiano Fidêncio wrote:
>> The only reason for us to keep maintaining the nsis installer was the
>> activex plugin (spicex), which requires those nsis based installers.
>> As the next release of RHEV/oVirt won't use the activex plugin (spicex)
>> let's completely remove the nsis installer from our tree and focus on
>> only maintain the msi installer.
>
> Maybe mention that currently ovirt/rhev is shipping virt-viewer from the
> 2.x branch, so it's no big deal to remove it in git master?
>
>
>>
>> Related: rhbz#1324885 and rhbz#1316560
>> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>> ---
>>  configure.ac                   |   2 -
>>  data/Makefile.am               |  23 +-
>>  data/virt-viewer-debug.nsis.in |  49 ----
>>  data/virt-viewer.nsis.in       | 604 -----------------------------------------
>
> After this patch, there is still a 'nsis' phony target in the toplevel
> Makefile.am.
> With these fixed:
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
>
> Christophe




More information about the virt-tools-list mailing list