[virt-tools-list] [PATCH v1] virtinst: set preserve when on_crash in s390x

[Cole Robinson]

On 05/10/2016 09:24 AM, Leno Hou wrote:
> When booting from empty disk image or none bootdev, its leads
> system IPL enter into infinite loop with message on s390x.
> This patch sets preserve when on_crash to avoid the loop.
> 

Is this correct behavior, or is this a qemu or guest OS bug? If it's something
that's going to be fixed eventually I'd rather not add it to virtinst. Is
there a bug report somewhere I can look at?

> Signed-off-by: Leno Hou <lenohou at gmail.com>
> ---
>  virtinst/guest.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index ab6dcba..67b1180 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -358,6 +358,8 @@ class Guest(XMLBuilder):
>          if install:
>              self.on_reboot = "destroy"
>              self.on_crash = "destroy"
> +	elif self.os.is_s390x():
> +            self.on_crash = "preserve"
>  

Also, it looks like the indentation is incorrect

Thanks,
Cole

>          self._set_osxml_defaults()
>  
>