[virt-tools-list] [PATCH virt-viewer 1/2] app: Use debug to inform about smartcard shortcuts state

[Pavel Grunt]

On Mon, 2016-05-30 at 11:35 +0200, Christophe Fergeau wrote:
> For what it's worth, smartcard shortcuts are not meant to be used in
> normal setups, I guess that's why there was a warning when enabling them
> (?). Not saying I object to the patch though ;) 
> 

The point is should a "normal" user be informed about smartcards shortcuts by a
warning message ? I don't think so, because it has no value for the user.

otoh if a smartcard shortcuts are requested by specifying hotkeys for them, then
the user should be informed that they are disabled...

Pavel

> Christophe
> 
> On Mon, May 30, 2016 at 11:25:34AM +0200, Pavel Grunt wrote:
> > Related: rhbz#1339572
> > ---
> >  src/virt-viewer-app.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> > index 6573961..d449f72 100644
> > --- a/src/virt-viewer-app.c
> > +++ b/src/virt-viewer-app.c
> > @@ -1762,7 +1762,7 @@ virt_viewer_update_smartcard_accels(VirtViewerApp
> > *self)
> >          sw_smartcard = FALSE;
> >      }
> >      if (sw_smartcard) {
> > -        g_warning("enabling smartcard shortcuts");
> > +        g_debug("enabling smartcard shortcuts");
> >          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-insert",
> >                                     priv->insert_smartcard_accel_key,
> >                                     priv->insert_smartcard_accel_mods,
> > @@ -1772,7 +1772,7 @@ virt_viewer_update_smartcard_accels(VirtViewerApp
> > *self)
> >                                     priv->remove_smartcard_accel_mods,
> >                                     TRUE);
> >      } else {
> > -        g_warning("disabling smartcard shortcuts");
> > +        g_debug("disabling smartcard shortcuts");
> >          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-insert",
> > 0, 0, TRUE);
> >          gtk_accel_map_change_entry("<virt-viewer>/file/smartcard-remove",
> > 0, 0, TRUE);
> >      }
> > -- 
> > 2.8.3
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list