[virt-tools-list] [PATCH virt-viewer v2 5/5] app: Inform about problematic hotkey

Pavel Grunt pgrunt at redhat.com
Mon May 30 15:08:40 UTC 2016


Resolves: rhbz#1339572
---
 src/virt-viewer-app.c | 2 +-
 tests/test-hotkeys.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index f8fba4c..3234e68 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -2066,7 +2066,7 @@ virt_viewer_app_set_hotkeys(VirtViewerApp *self, const gchar *hotkeys_str)
     for (hotkey = hotkeys; *hotkey != NULL; hotkey++) {
         gchar *key = strstr(*hotkey, "=");
         if (key == NULL) {
-            g_warn_if_reached();
+            g_warning("missing value for key '%s'", *hotkey);
             continue;
         }
         *key = '\0';
diff --git a/tests/test-hotkeys.c b/tests/test-hotkeys.c
index 4a45216..24fd971 100644
--- a/tests/test-hotkeys.c
+++ b/tests/test-hotkeys.c
@@ -91,7 +91,7 @@ test_hotkeys_bad(void)
         {
             "no_value",
             G_LOG_LEVEL_WARNING,
-            "*code should not be reached"
+            "missing value for key 'no_value'"
         },{
             "toggle-fullscreen=A,unknown_command=B",
             G_LOG_LEVEL_WARNING,
-- 
2.8.3




More information about the virt-tools-list mailing list