[virt-tools-list] [PATCH virt-viewer v3 0/3] Improve warning messages for hotkeys parsing

Pavel Grunt pgrunt at redhat.com
Tue May 31 09:01:21 UTC 2016


These patches changes/improves/add warning messages when a problem occurs during
parsing of hotkeys.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1339572

Changes since v2 - per Fabiano's review:
 - Consider "foo=" as invalid (also squashed "app: Inform about problematic hotkey")
 - improved commit messages

Changes since v1:
 - Added tests
 - Added a warning when hotkey's value is invalid


Pavel Grunt (3):
  app: Use debug to inform about smartcard shortcuts state
  tests: Add hotkeys test
  app: Check validity of hotkey

 src/virt-viewer-app.c |  17 ++++---
 tests/Makefile.am     |  12 ++++-
 tests/test-hotkeys.c  | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 153 insertions(+), 7 deletions(-)
 create mode 100644 tests/test-hotkeys.c


More information about the virt-tools-list mailing list