[virt-tools-list] [PATCH virt-viewer] !fixup Simplify file transfer dialog UI

Jonathon Jongsma jjongsma at redhat.com
Wed Nov 2 16:04:05 UTC 2016


Apologies. I've pushed a trivial build fix.


On Wed, 2016-11-02 at 16:00 +0000, Daniel P. Berrange wrote:
> On Thu, Oct 27, 2016 at 02:33:08PM -0500, Jonathon Jongsma wrote:
> > 
> > ---
> > Includes fixes from Pavel and Fabiano's reviews
> > 
> >  src/resources/ui/virt-viewer-file-transfer-dialog.ui | 12 +++++++-
> > ----
> >  src/virt-viewer-file-transfer-dialog.c               |  6 +++---
> >  2 files changed, 10 insertions(+), 8 deletions(-)
> > 
> 
> > 
> > diff --git a/src/virt-viewer-file-transfer-dialog.c b/src/virt-
> > viewer-file-transfer-dialog.c
> > index 3339ba4..cd1b4aa 100644
> > --- a/src/virt-viewer-file-transfer-dialog.c
> > +++ b/src/virt-viewer-file-transfer-dialog.c
> > @@ -58,7 +58,7 @@
> > virt_viewer_file_transfer_dialog_class_init(VirtViewerFileTransferD
> > ialogClass *k
> >      GtkWidgetClass *widget_class = GTK_WIDGET_CLASS(klass);
> >  
> >      gtk_widget_class_set_template_from_resource(widget_class,
> > -                                                "/org/virt-
> > manager/virt-viewer/ui/virt-viewer-file-transfer-dialog.ui");
> > +                                                VIRT_VIEWER_RESOUR
> > CE_PREFIX "/ui/virt-viewer-file-transfer-dialog.ui");
> 
> 
> This appears to have broken the build
> 
> ../../src/virt-viewer-file-transfer-dialog.c: In function
> 'virt_viewer_file_transfer_dialog_class_init':
> ../../src/virt-viewer-file-transfer-dialog.c:62:49: error:
> 'VIRT_VIEWER_RESOURCE_PREFIX' undeclared (first use in this function)
>                                                  VIRT_VIEWER_RESOURCE
> _PREFIX "/ui/virt-viewer-file-transfer-dialog.ui");
>                                                  ^~~~~~~~~~~~~~~~~~~~
> ~~~~~~~
> ../../src/virt-viewer-file-transfer-dialog.c:62:49: note: each
> undeclared identifier is reported only once for each function it
> appears in
> ../../src/virt-viewer-file-transfer-dialog.c:62:77: error: expected
> ')' before string constant
>                                                  VIRT_VIEWER_RESOURCE
> _PREFIX "/ui/virt-viewer-file-transfer-dialog.ui");
>                                                                      
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> make[3]: *** [Makefile:930: libvirt_viewer_la-virt-viewer-file-
> transfer-dialog.lo] Error 1
> 
> 
> 
> Regards,
> Daniel




More information about the virt-tools-list mailing list