[virt-tools-list] [PATCH virt-viewer] app: Inform user about connection failure

Pavel Grunt pgrunt at redhat.com
Wed Oct 5 12:18:15 UTC 2016


On Wed, 2016-10-05 at 14:13 +0200, Christophe Fergeau wrote:
> On Wed, Oct 05, 2016 at 01:54:57PM +0200, Pavel Grunt wrote:
> > If the errors are going to be presented to the user, g_strerror()
> > is
> > not
> > the nicest message we can show.
> 
> 
> Yes, these messages will be shown in the error dialog.
> What do you suggest ? Have some predefined strings and keep
> g_strerror
> as a fallback ?
> otoh messages provided by g_strerror are translated.
> 
> 
> What GNOME applications try to do is to indeed just use user-
> friendly
> strings. However virt-viewer hasn't been doing that, and would be
> much more work than just this patch. But I think we should at least
> prefix the message to say that something went wrong with the
> connection
> to the Unix socket or something like that
> 
Thanks, I will send a v2

Pavel


> Christophe
> 




More information about the virt-tools-list mailing list