[virt-tools-list] [PATCH 2/5] virtinst: check minimum qemu/libvirt for spice+gl

[Cole Robinson]

On 10/06/2016 10:41 AM, Marc-André Lureau wrote:
> Hi Cole
> 
> On Sun, May 8, 2016 at 3:36 AM Cole Robinson <crobinso at redhat.com
> <mailto:crobinso at redhat.com>> wrote:
> 
>     On 04/28/2016 08:22 AM, Marc-André Lureau wrote:
>     > Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com
>     <mailto:marcandre.lureau at redhat.com>>
>     > ---
>     >  virtinst/guest.py   | 5 +++++
>     >  virtinst/support.py | 1 +
>     >  2 files changed, 6 insertions(+)
>     >
>     > diff --git a/virtinst/guest.py b/virtinst/guest.py
>     > index ab6dcba..5824e87 100644
>     > --- a/virtinst/guest.py
>     > +++ b/virtinst/guest.py
>     > @@ -1141,6 +1141,11 @@ class Guest(XMLBuilder):
>     >                  if dev.image_compression is None:
>     >                      dev.image_compression = "off"
>     >
>     > +            if (dev.type == "spice" and
>     > +                 not self.conn.check_support(
>     > +                     self.conn.SUPPORT_CONN_SPICE_GL)):
>     > +                 raise ValueError(_("Host does not support spice GL"))
>     > +
>     >      def _add_spice_channels(self):
>     >          if self.skip_default_channel:
>     >              return
>     > diff --git a/virtinst/support.py b/virtinst/support.py
>     > index 1071750..1925986 100644
>     > --- a/virtinst/support.py
>     > +++ b/virtinst/support.py
>     > @@ -311,6 +311,7 @@ SUPPORT_CONN_VCPU_PLACEMENT = _make(
>     >  SUPPORT_CONN_MEM_STATS_PERIOD = _make(
>     >      function="virDomain.setMemoryStatsPeriod",
>     >      version="1.1.1", hv_version={"qemu": 0})
>     > +SUPPORT_CONN_SPICE_GL = _make(version="1.3.3", hv_version={"qemu":
>     "2.5.92"})
>     >
> 
>     If we are going to wait for the libvirt listen type=none, maybe we can avoid
>     this and use libvirt domcapabilities instead. It's on my todo list to use
>     domcapabilities to advertise spice gl bits. We will see how this libvirt
>     release cycle goes
> 
> 
> Any news regarding domcapabilities? Should we go with that patch instead for now?

I started a domcapabilities discussion here:

https://www.redhat.com/archives/libvir-list/2016-April/msg01839.html

But the amount of work required was more than I could handle at that time, so
it was shelved.

I did end up pushing a variant of this patch, that for virt-install will print
a warning if we don't think libvirt+qemu support spice GL, but it's non-fatal
since there's not really any complete way for us to be sure spice GL is
supported or not

commit 635a228f6be8b7e254180447811643c9cd1cbad2
Author: Cole Robinson <crobinso at redhat.com>
Date:   Fri May 20 12:44:13 2016 -0400

    cli: Warn if we think spice GL settings won't work

- Cole