[virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

Eduardo Lima (Etrunko) etrunko at redhat.com
Tue Sep 6 12:47:19 UTC 2016


On 08/04/2016 12:09 AM, Xiaodai Wang wrote:
> ----- Original Message -----
>> From: "Fabiano Fidêncio" <fidencio at redhat.com>
>> To: "Eduardo Lima (Etrunko)" <etrunko at redhat.com>
>> Cc: "Christophe Fergeau" <cfergeau at redhat.com>, "virt" <virt-tools-list at redhat.com>
>> Sent: Wednesday, August 3, 2016 10:36:07 PM
>> Subject: Re: [virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog
>>
>> On Wed, Aug 3, 2016 at 3:04 PM, Eduardo Lima (Etrunko)
>> <etrunko at redhat.com> wrote:
>>> On 08/02/2016 01:17 PM, Christophe Fergeau wrote:
>>>> On Fri, Jul 29, 2016 at 06:40:23PM -0300, Eduardo Lima (Etrunko) wrote:
>>>>> I have pushed the first two patches of the series because they were
>>>>> already acknowledged and were pretty much self-contained.
>>>>>
>>>>> I tried to replace GtkTreeView in favor of new GtkListBox, but after some
>>>>> painful work, I decided to drop it because it is not possible to
>>>>> reproduce the exact same behavior of the former with the latter. For
>>>>> instance, once we have a GtkRadioButton activated, it is not possible to
>>>>> deactivate it.
>>>>
>>>> For what it's worth, I'm not sure we should keep GtkRadioButtons at all
>>>> cost in the list, imo they look not so nice. Dunno if it would be
>>>> possibe to have either empty column or check mark instead of a
>>>> GtkRadioButton.
>>>>
>>>
>>> Well, I am no UI expert, but it seems to me that radio buttons are the
>>> best choice to express the behavior of the list, exactly 1 or 0 item can
>>> be active at any given time. With check buttons, user is given the
>>> impression that more than once can be selected, which is not the case.
>>
>> I do agree with Eduardo here.
>> I have the feeling that radio buttons are the most suitable option here.
>>
> 
> How about the UI for "Attach CD" option in ovirt portal.
> 
> You can find it in "Edit Virtual Machine" dialog, then select "Boot Options".
> 
> Or How about the "Change CD" dialog? 
> 


Hi Xiaodai,

I'm sorry I didn't reply to your message earlier, I somehow missed it.

Well, I looked at the option you mentioned, and in Gtk+ the equivalent
widget would be a ComboBox, but it seems to have the same problems as
the old menu item we are trying to replace. When there are lots of items
to show, it will expand to the limits of the screen.

Regards, Eduardo


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list