[virt-tools-list] [virt-manager] [PATCH 5/5] pycodestyle: Do not use bare 'except:'

Cole Robinson crobinso at redhat.com
Wed Aug 2 18:36:23 UTC 2017


On 07/24/2017 04:26 AM, Radostin Stoyanov wrote:
> A bare 'except:' catches all exceptions [1], including SystemExit,
> KeyboardInterrupt, and GeneratorExit (which is not an error and should
> not normally be caught by user code). In situations where you need to
> catch all “normal” errors, you can catch the base class for all normal
> exceptions, Exception [2].
> 
> [1] https://docs.python.org/2/howto/doanddont.html#except
> [2] https://docs.python.org/2/library/exceptions.html#Exception

Huh, I never knew that distinction, I thought SystemExit always needed to be
caught explicitly. Thanks for the explanation, I've pushed this patch now

Thanks,
Cole




More information about the virt-tools-list mailing list