[virt-tools-list] [virt-bootstrap] [PATCH v4 09/26] DockerSoure: Keep list of tar files for image

[Cedric Bosdonnat]

You should add a rationale here: looking at the commit and title
I can't guess why you had to do this and can only guess it's a good thing.

On Thu, 2017-08-03 at 14:13 +0100, Radostin Stoyanov wrote:
> ---
>  src/virtBootstrap/sources/docker_source.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/virtBootstrap/sources/docker_source.py b/src/virtBootstrap/sources/docker_source.py
> index 54d8903..63865d8 100644
> --- a/src/virtBootstrap/sources/docker_source.py
> +++ b/src/virtBootstrap/sources/docker_source.py
> @@ -65,6 +65,7 @@ class DockerSource(object):
>          self.images_dir = utils.get_image_dir(self.no_cache)
>          self.manifest = None
>          self.layers = []
> +        self.tar_files = []
>  
>          if self.username and not self.password:
>              self.password = getpass.getpass()
> @@ -96,6 +97,7 @@ class DockerSource(object):
>  
>              sum_type, layer_sum = layer_digest.split(':')
>              file_path = os.path.join(self.images_dir, layer_sum + '.tar')
> +            self.tar_files.append(file_path)
>              self.layers.append([sum_type, layer_sum, file_path, layer_size])
>  
>      def gen_valid_uri(self, uri):

ACK with a rationale as description
--
Cedric