[virt-tools-list] [PATCH 1/4] Improve container image url example

Pavel Hrdina phrdina at redhat.com
Tue Dec 19 12:59:23 UTC 2017


On Thu, Dec 14, 2017 at 10:03:55AM +0100, Cédric Bosdonnat wrote:
> From: Cédric Bosdonnat <cedric.bosdonnat at free.fr>
> 
> Replace the docker://fedora example by a string that shows more of the
> possible values, like how to specify a user or server. While at it,
> the image name is no distro agnostic.

I actually prefer a working example than some string to show more of the
possible values.  To give user a hint, what are all possible values
tooltip would be better with some description and possible pointer
to some documentation.

Pavel

> ---
>  ui/create.ui | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/create.ui b/ui/create.ui
> index dd50cdf0..142a7356 100644
> --- a/ui/create.ui
> +++ b/ui/create.ui
> @@ -1776,7 +1776,7 @@ connections is not yet supported.</small></property>
>                                                      <child internal-child="entry">
>                                                        <object class="GtkEntry" id="install-oscontainer-source-url-entry">
>                                                          <property name="can_focus">True</property>
> -                                                        <property name="placeholder_text" translatable="yes">docker://fedora</property>
> +                                                        <property name="placeholder_text" translatable="yes">docker://srv:1234/myimg:tag</property>
>                                                        </object>
>                                                      </child>
>                                                    </object>
> -- 
> 2.15.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20171219/28901661/attachment.sig>


More information about the virt-tools-list mailing list