[virt-tools-list] [virt-manager][PATCH] py3: store exception variables for use outside except

[Cole Robinson]

On 12/20/2017 12:14 PM, Cédric Bosdonnat wrote:
> In python3 exceptions aren't defined outside the except block. Leading
> to 'UnboundLocalError: local variable 'e' referenced before assignment'
> errors.
> 
> To work around this, store the local variable into one that will have a
> longer life.
> ---
>  virtManager/connection.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/connection.py b/virtManager/connection.py
> index c98fff3d..f9da6677 100644
> --- a/virtManager/connection.py
> +++ b/virtManager/connection.py
> @@ -1439,7 +1439,8 @@ class vmmConnection(vmmGObject):
>              self._tick(*args, **kwargs)
>          except KeyboardInterrupt:
>              raise
> -        except Exception as e:
> +        except Exception as err:
> +            e = err
>              pass
>  
>          if e is None:
> 

ACK and pushed, and I hit another instance of this while trying to test
it too :)

Thanks,
Cole