[virt-tools-list] [PATCH virt-viewer] iso-dialog: Do not use string directly

Eduardo Lima (Etrunko) etrunko at redhat.com
Mon Feb 6 13:10:15 UTC 2017


Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>

On 06/02/17 10:02, Pavel Grunt wrote:
> Fixes -Werror=format-security used when creating the rpm
> ---
> see: https://copr-be.cloud.fedoraproject.org/results/pgrunt/spice-upstream/fedora-25-x86_64/00507878-virt-viewer/build.log.gz
> ---
>  src/remote-viewer-iso-list-dialog.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/remote-viewer-iso-list-dialog.c b/src/remote-viewer-iso-list-dialog.c
> index f23ddb2..2ab5435 100644
> --- a/src/remote-viewer-iso-list-dialog.c
> +++ b/src/remote-viewer-iso-list-dialog.c
> @@ -286,7 +286,7 @@ remote_viewer_iso_list_dialog_show_error(RemoteViewerISOListDialog *self,
>                                      GTK_DIALOG_DESTROY_WITH_PARENT,
>                                      GTK_MESSAGE_ERROR,
>                                      GTK_BUTTONS_CLOSE,
> -                                    message ? message : _("Unspecified error"));
> +                                    "%s", message ? message : _("Unspecified error"));
>      gtk_dialog_run(GTK_DIALOG(dialog));
>      gtk_widget_destroy(dialog);
>  }
> 


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list