[virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

Christophe de Dinechin cdupontd at redhat.com
Thu Feb 9 13:22:58 UTC 2017


>> 
>> If the message is NULL, we should still display something like
>> “unknown error”. If we think it’s worth testing for error->message
>> != NULL, then I suggest another patch just for that, that fixes all
>> places and not just this one.
> I agree

Separate patch sent.


>> BTW, I did not find where the localization strings for the project
>> were stored. How does localization happen ? If I add a new message,
>> who should I warn to have the message translated?
> It is handled in zanata https://fedora.zanata.org/iteration/view/virt-
> viewer/master?dswid=3794

Thanks. I guess my question is: how is the list of translatable strings updated? Is that done automatically as part of the build?

I’m asking because if I touch a source file and then run ‘make’ in the po directory, nothing is made. There is a list of source files. So I think it should update the .po files. I’m afraid I’m not doing something I should do to make it clear a new string was added (besides adding the _(“foo”) marker). Am I supposed to run xgettext manually? In Tao3D, we have a ‘make lupdate’ target for this purpose, the Qt tool being called lupdate.


Thanks,
Christophe





More information about the virt-tools-list mailing list