[virt-tools-list] [virt-viewer PATCH] Show errors generated by connection dialog

[Pavel Grunt]

On Thu, 2017-02-09 at 14:22 +0100, Christophe de Dinechin wrote:
> > > 
> > > If the message is NULL, we should still display something like
> > > “unknown error”. If we think it’s worth testing for error-
> > > >message
> > > != NULL, then I suggest another patch just for that, that fixes
> > > all
> > > places and not just this one.
> > 
> > I agree
> 
> Separate patch sent.
> 
> 
> > > BTW, I did not find where the localization strings for the
> > > project
> > > were stored. How does localization happen ? If I add a new
> > > message,
> > > who should I warn to have the message translated?
> > 
> > It is handled in zanata https://fedora.zanata.org/iteration/view/v
> > irt-
> > viewer/master?dswid=3794
> 
> Thanks. I guess my question is: how is the list of translatable
> strings updated? Is that done automatically as part of the build?

irrc you must download translation from zanata and do
`make -C po update-po`

> 
> I’m asking because if I touch a source file and then run ‘make’ in
> the po directory, nothing is made. There is a list of source files.
> So I think it should update the .po files. I’m afraid I’m not doing
> something I should do to make it clear a new string was added
> (besides adding the _(“foo”) marker). Am I supposed to run xgettext
> manually? In Tao3D, we have a ‘make lupdate’ target for this
> purpose, the Qt tool being called lupdate.
> 
yeah, that make update-po should work

> 
> Thanks,
> Christophe
>