[virt-tools-list] [virt-manager PATCH v2 8/9] details: refresh Information page on inspection data change

[Pino Toscano]

On Thursday, 23 February 2017 11:03:25 CET Richard W.M. Jones wrote:
> On Thu, Feb 23, 2017 at 11:22:26AM +0100, Pino Toscano wrote:
> > Refresh the 'Information' page when there are new inspection data
> > available, so they can be seen even without switching to a different
> > page and back.  This could be seen when starting virt-manager, and
> > opening quickly the 'Information' page of an uninspected guest.
> > ---
> >  virtManager/details.py | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/virtManager/details.py b/virtManager/details.py
> > index 0503a44..ca097cc 100644
> > --- a/virtManager/details.py
> > +++ b/virtManager/details.py
> > @@ -580,6 +580,7 @@ class vmmDetails(vmmGObjectUI):
> >          # Deliberately keep all this after signal connection
> >          self.vm.connect("state-changed", self.refresh_vm_state)
> >          self.vm.connect("resources-sampled", self.refresh_resources)
> > +        self.vm.connect("inspection-changed", lambda *x: self.refresh_inspection_page())
> >  
> >          self.populate_hw_list()
> 
> If I'm reading the code correctly, before this commit was the
> inspection-changed signal generated but never consumed anywhere?

It has been used already to refresh the icon of a VM in the list of VMs
(in the main virt-manager window), see vmmManager.vm_inspection_changed.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170223/c0321ff4/attachment.sig>