[virt-tools-list] [PATCH virt-viewer 07/10] iso-dialog: Implement functionality provided by oVirt foreign menu

Christophe Fergeau cfergeau at redhat.com
Tue Jan 17 16:01:25 UTC 2017


On Fri, Jan 13, 2017 at 07:11:09PM -0200, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  src/remote-viewer-iso-list-dialog.c        | 205 ++++++++++++++++++++++++++++-
>  src/resources/ui/remote-viewer-iso-list.ui |   5 +-
>  2 files changed, 206 insertions(+), 4 deletions(-)
> 
> diff --git a/src/remote-viewer-iso-list-dialog.c b/src/remote-viewer-iso-list-dialog.c
> index 858719c..00371ff 100644
> --- a/src/remote-viewer-iso-list-dialog.c
> +++ b/src/remote-viewer-iso-list-dialog.c
> @@ -20,12 +20,16 @@
>  
>  #include <config.h>
>  
> +#include <stdlib.h>

This is added because you call free() in a few places, but why are you
not using g_free() in these places?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170117/dc21258f/attachment.sig>


More information about the virt-tools-list mailing list