[virt-tools-list] [PATCH virt-viewer 5/9] ovirt-foreign-menu: Add accessors for current iso and iso list

[Eduardo Lima (Etrunko)]

On 19/01/17 10:55, Christophe Fergeau wrote:
> On Wed, Jan 18, 2017 at 12:16:56PM -0200, Eduardo Lima (Etrunko) wrote:
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  src/ovirt-foreign-menu.c | 11 +++++++++--
>>  src/ovirt-foreign-menu.h |  2 ++
>>  2 files changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
>> index 50a8ea6..e2216a2 100644
>> --- a/src/ovirt-foreign-menu.c
>> +++ b/src/ovirt-foreign-menu.c
>> @@ -85,10 +85,10 @@ enum {
>>  };
>>  
>>  
>> -static char *
>> +gchar *
>>  ovirt_foreign_menu_get_current_iso_name(OvirtForeignMenu *foreign_menu)
>>  {
>> -    char *name;
>> +    gchar *name;
>>  
>>      if (foreign_menu->priv->cdrom == NULL) {
>>          return NULL;
> 
> Note that before we were returning a char * and using g_free on the
> string. The rest of the codebase seems to be using gchar * consistently
> as a return value though. Might be better to have that as a separate
> commit? On the one hand, it's so small that it's overkill, on the other
> hand, the hunk is odd when squashed with a different commit.

I guess it could be documented on the the commit message, to explain the
change.


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20170119/2a125cd5/attachment.sig>