[virt-tools-list] [virt-bootstrap] [PATCH v5 04/11] DockerSource: Show correct err msg on skopeo fail

Radostin Stoyanov rstoyanov1 at gmail.com
Mon Jul 24 08:14:04 UTC 2017


The first argument of CalledProcessError() must be the returncode not
the command.
---
 src/virtBootstrap/sources.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/virtBootstrap/sources.py b/src/virtBootstrap/sources.py
index 898993d..c44b2ed 100644
--- a/src/virtBootstrap/sources.py
+++ b/src/virtBootstrap/sources.py
@@ -264,7 +264,7 @@ class DockerSource(object):
         # Without `make_async`, `fd.read` in `read_async` blocks.
         utils.make_async(proc.stdout)
         if not self.parse_output(proc):
-            raise CalledProcessError(cmd, proc.stderr.read())
+            raise CalledProcessError(proc.returncode, ' '.join(cmd))
 
     def validate_image_layers(self):
         """
-- 
2.9.4




More information about the virt-tools-list mailing list