[virt-tools-list] [virt-viewer v3] spice: do not show error on cancel/close of auth dialog

Pavel Grunt pgrunt at redhat.com
Fri Jun 2 12:57:25 UTC 2017


On Fri, 2017-06-02 at 14:05 +0200, Victor Toso wrote:
> From: Victor Toso <me at victortoso.com>
> 
> Mainly an issue for kiosk mode.
> 
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1446161
> Signed-off-by: Victor Toso <victortoso at redhat.com>
> ---
>  src/virt-viewer-session-spice.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-
> session-spice.c
> index 5f326aa..106abd1 100644
> --- a/src/virt-viewer-session-spice.c
> +++ b/src/virt-viewer-session-spice.c
> @@ -725,6 +725,10 @@
> virt_viewer_session_spice_main_channel_event(SpiceChannel *channel,
>          g_free(host);
>          if (!ret) {
>              g_signal_emit_by_name(session, "session-cancelled");
> +            /* ret is false when dialog did not return
> GTK_RESPONSE_OK. We
> +             * should ignore auth error dialog if user has
> cancelled or closed
> +             * the dialog */
> +            self->priv->pass_try = 0;

I'd first change the value and after that emit the signal.

Acked-by: Pavel Grunt <pgrunt at redhat.com>

Thanks,
Pavel Grunt

>          } else {
>              gboolean openfd;
>  




More information about the virt-tools-list mailing list