[virt-tools-list] [virt-manager] [PATCH 2/2] Set default Filesystem type for LXC to "Mount"

Cole Robinson crobinso at redhat.com
Fri Jun 16 18:02:59 UTC 2017


On 06/16/2017 06:32 AM, Radostin Stoyanov wrote:
> ---
>  virtinst/devicefilesystem.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virtinst/devicefilesystem.py b/virtinst/devicefilesystem.py
> index be8f841..5c1645f 100644
> --- a/virtinst/devicefilesystem.py
> +++ b/virtinst/devicefilesystem.py
> @@ -123,7 +123,7 @@ class VirtualFilesystem(VirtualDevice):
>      def set_defaults(self, guest):
>          ignore = guest
>  
> -        if self.conn.is_qemu() or self.conn.is_test():
> +        if self.conn.is_qemu() or self.conn.is_lxc() or self.conn.is_test():
>              # type=mount is the libvirt qemu default. But hardcode it
>              # here since we need it for the accessmode check
>              if self.type is None or self.type == self.TYPE_DEFAULT:
> 

The comment below it mentions qemu, but I think type=mount is the libvirt
default in general, so please adjust that as well. Also this might cause test
suite churn as well, so check that too and --regenerate-output if required

Thanks,
Cole




More information about the virt-tools-list mailing list