[virt-tools-list] [virt-manager PATCHv2 06/13] Use valign property instead of yalign

Radostin Stoyanov rstoyanov1 at gmail.com
Wed May 31 13:08:36 UTC 2017


GtkAlignment:yalign was deprecated since Gtk version 3.14 and
should not be used in newly-written code. Use valign property instead.

The behaviour of yalign='0' is identical to valign='start', similar
for yalign='1' and valign='end'. The default value of the property
valign is GTK_ALIGN_FILL which has simmilar behaviour to yalign='0.5'.

https://developer.gnome.org/gtk3/stable/GtkAlignment.html#GtkAlignment--yalign

https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--valign
---
 ui/addhardware.ui |  2 +-
 ui/asyncjob.ui    |  6 +++---
 ui/choosecd.ui    |  2 +-
 ui/clone.ui       | 10 +++++-----
 ui/connect.ui     |  3 +--
 ui/create.ui      |  8 ++++----
 ui/createnet.ui   |  8 ++++----
 ui/details.ui     | 14 +++++++-------
 ui/gfxdetails.ui  |  3 +--
 ui/host.ui        |  8 ++++----
 ui/migrate.ui     |  4 ++--
 ui/netlist.ui     |  2 +-
 ui/snapshots.ui   |  8 ++++----
 13 files changed, 38 insertions(+), 40 deletions(-)

diff --git a/ui/addhardware.ui b/ui/addhardware.ui
index 80be23a..0350240 100644
--- a/ui/addhardware.ui
+++ b/ui/addhardware.ui
@@ -82,12 +82,12 @@
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">start</property>
+                        <property name="valign">start</property>
                         <property name="xpad">6</property>
                         <property name="ypad">6</property>
                         <property name="label">Page title</property>
                         <property name="use_markup">True</property>
                         <property name="justify">fill</property>
-                        <property name="yalign">0</property>
                       </object>
                     </child>
                   </object>
diff --git a/ui/asyncjob.ui b/ui/asyncjob.ui
index 7859e83..bbfe07f 100644
--- a/ui/asyncjob.ui
+++ b/ui/asyncjob.ui
@@ -29,7 +29,7 @@
               <object class="GtkImage" id="image99">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
-                <property name="yalign">0</property>
+                <property name="valign">start</property>
                 <property name="xpad">3</property>
                 <property name="ypad">10</property>
                 <property name="stock">gtk-dialog-info</property>
@@ -46,11 +46,11 @@
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
                 <property name="halign">start</property>
+                <property name="valign">start</property>
                 <property name="label" translatable="yes">Please wait a few moments...</property>
                 <property name="wrap">True</property>
                 <property name="width_chars">50</property>
                 <property name="max_width_chars">50</property>
-                <property name="yalign">0</property>
               </object>
               <packing>
                 <property name="expand">True</property>
@@ -110,10 +110,10 @@
             <property name="visible">True</property>
             <property name="can_focus">False</property>
             <property name="halign">start</property>
+            <property name="valign">start</property>
             <property name="xpad">3</property>
             <property name="ypad">3</property>
             <property name="label" translatable="yes">Processing...</property>
-            <property name="yalign">0</property>
           </object>
           <packing>
             <property name="expand">False</property>
diff --git a/ui/choosecd.ui b/ui/choosecd.ui
index bfb9b5b..79c1b28 100644
--- a/ui/choosecd.ui
+++ b/ui/choosecd.ui
@@ -147,7 +147,7 @@
                       <object class="GtkAlignment" id="alignment5">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="yalign">0</property>
+                        <property name="valign">start</property>
                         <property name="yscale">0</property>
                         <child>
                           <object class="GtkRadioButton" id="iso-image">
diff --git a/ui/clone.ui b/ui/clone.ui
index e451811..ad08597 100644
--- a/ui/clone.ui
+++ b/ui/clone.ui
@@ -219,9 +219,9 @@
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="halign">end</property>
+                                <property name="valign">start</property>
                                 <property name="label" translatable="yes"><span color='#484848'>Networking:</span></property>
                                 <property name="use_markup">True</property>
-                                <property name="yalign">0</property>
                               </object>
                               <packing>
                                 <property name="top_attach">1</property>
@@ -348,9 +348,9 @@
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="halign">end</property>
+                                <property name="valign">start</property>
                                 <property name="label" translatable="yes"><span color='#484848'>Storage:</span></property>
                                 <property name="use_markup">True</property>
-                                <property name="yalign">0</property>
                               </object>
                               <packing>
                                 <property name="top_attach">2</property>
@@ -417,7 +417,7 @@
                           <object class="GtkImage" id="image6">
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
-                            <property name="yalign">0</property>
+                            <property name="valign">start</property>
                             <property name="stock">gtk-info</property>
                           </object>
                           <packing>
@@ -459,7 +459,7 @@ uses the existing disk image for both the original and the new machine.</span
                             <property name="visible">True</property>
                             <property name="can_focus">False</property>
                             <property name="halign">start</property>
-                            <property name="yalign">0</property>
+                            <property name="valign">start</property>
                             <property name="stock">gtk-dialog-warning</property>
                           </object>
                           <packing>
@@ -951,9 +951,9 @@ like change passwords or static IPs, please see the virt-sysprep(1) tool.</sp
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
                         <property name="halign">end</property>
+                        <property name="valign">end</property>
                         <property name="label" translatable="yes"><span color='#484848'>Size:</span></property>
                         <property name="use_markup">True</property>
-                        <property name="yalign">1</property>
                       </object>
                       <packing>
                         <property name="top_attach">2</property>
diff --git a/ui/connect.ui b/ui/connect.ui
index 5fcc6d8..a3acb58 100644
--- a/ui/connect.ui
+++ b/ui/connect.ui
@@ -257,7 +257,6 @@
                 <property name="use_markup">True</property>
                 <property name="use_underline">True</property>
                 <property name="mnemonic_widget">username-entry</property>
-                <property name="yalign">0.51999998092651367</property>
               </object>
               <packing>
                 <property name="left_attach">0</property>
@@ -289,7 +288,7 @@
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
                     <property name="halign">start</property>
-                    <property name="yalign">0</property>
+                    <property name="valign">start</property>
                     <property name="stock">gtk-dialog-warning</property>
                   </object>
                   <packing>
diff --git a/ui/create.ui b/ui/create.ui
index f25ea42..f1c27cd 100644
--- a/ui/create.ui
+++ b/ui/create.ui
@@ -516,8 +516,8 @@
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
+                                    <property name="valign">start</property>
                                     <property name="hexpand">False</property>
-                                    <property name="yalign">0</property>
                                     <property name="stock">gtk-dialog-warning</property>
                                   </object>
                                   <packing>
@@ -530,12 +530,12 @@
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
+                                    <property name="valign">start</property>
                                     <property name="hexpand">False</property>
                                     <property name="label">Error message
 bar</property>
                                     <property name="wrap">True</property>
                                     <property name="max_width_chars">45</property>
-                                    <property name="yalign">0</property>
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
@@ -573,8 +573,8 @@ bar</property>
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
+                                    <property name="valign">start</property>
                                     <property name="hexpand">False</property>
-                                    <property name="yalign">0</property>
                                     <property name="stock">gtk-dialog-warning</property>
                                   </object>
                                   <packing>
@@ -587,12 +587,12 @@ bar</property>
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
+                                    <property name="valign">start</property>
                                     <property name="hexpand">False</property>
                                     <property name="label">Error message
 bar</property>
                                     <property name="wrap">True</property>
                                     <property name="max_width_chars">45</property>
-                                    <property name="yalign">0</property>
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
diff --git a/ui/createnet.ui b/ui/createnet.ui
index da2945f..21b1db5 100644
--- a/ui/createnet.ui
+++ b/ui/createnet.ui
@@ -359,7 +359,7 @@
                                       <object class="GtkImage" id="image105">
                                         <property name="visible">True</property>
                                         <property name="can_focus">False</property>
-                                        <property name="yalign">0</property>
+                                        <property name="valign">start</property>
                                         <property name="xpad">3</property>
                                         <property name="ypad">3</property>
                                         <property name="stock">gtk-dialog-info</property>
@@ -381,12 +381,12 @@
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
                                             <property name="halign">start</property>
+                                            <property name="valign">start</property>
                                             <property name="label" translatable="yes"><b>Hint:</b> The network should be chosen from one of the IPv4 private address ranges. eg 10.0.0.0/8 or 192.168.0.0/16</property>
                                             <property name="use_markup">True</property>
                                             <property name="wrap">True</property>
                                             <property name="width_chars">40</property>
                                             <property name="max_width_chars">50</property>
-                                            <property name="yalign">0</property>
                                           </object>
                                           <packing>
                                             <property name="expand">False</property>
@@ -777,7 +777,7 @@
                                       <object class="GtkImage" id="image1">
                                         <property name="visible">True</property>
                                         <property name="can_focus">False</property>
-                                        <property name="yalign">0</property>
+                                        <property name="valign">start</property>
                                         <property name="xpad">3</property>
                                         <property name="ypad">3</property>
                                         <property name="stock">gtk-dialog-info</property>
@@ -799,11 +799,11 @@
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
                                             <property name="halign">start</property>
+                                            <property name="valign">start</property>
                                             <property name="label" translatable="yes"><b>Note:</b> The network could be chosen from one of the IPv6 private address ranges. eg FC00::/7.  The prefix must be <b>64</b>. A typical IPv6 network address will look something like:  fd00:e81d:a6d7:55::/64</property>
                                             <property name="use_markup">True</property>
                                             <property name="wrap">True</property>
                                             <property name="max_width_chars">45</property>
-                                            <property name="yalign">0</property>
                                           </object>
                                           <packing>
                                             <property name="expand">False</property>
diff --git a/ui/details.ui b/ui/details.ui
index fc796a2..857ab50 100644
--- a/ui/details.ui
+++ b/ui/details.ui
@@ -832,10 +832,10 @@
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
                                             <property name="halign">start</property>
+                                            <property name="valign">start</property>
                                             <property name="label" translatable="yes">D_escription:</property>
                                             <property name="use_underline">True</property>
                                             <property name="mnemonic_widget">overview-description</property>
-                                            <property name="yalign">0</property>
                                           </object>
                                           <packing>
                                             <property name="left_attach">0</property>
@@ -1020,8 +1020,8 @@
                                                     <property name="visible">True</property>
                                                     <property name="can_focus">False</property>
                                                     <property name="halign">start</property>
+                                                    <property name="valign">start</property>
                                                     <property name="hexpand">False</property>
-                                                    <property name="yalign">0</property>
                                                     <property name="stock">gtk-dialog-warning</property>
                                                   </object>
                                                   <packing>
@@ -1631,7 +1631,7 @@ if you know what you are doing.</small></property>
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
-                                    <property name="yalign">0</property>
+                                    <property name="valign">start</property>
                                     <property name="stock">gtk-dialog-warning</property>
                                   </object>
                                   <packing>
@@ -1644,9 +1644,9 @@ if you know what you are doing.</small></property>
                                     <property name="visible">True</property>
                                     <property name="can_focus">False</property>
                                     <property name="halign">start</property>
+                                    <property name="valign">start</property>
                                     <property name="label" translatable="yes">Error message bar</property>
                                     <property name="max_width_chars">80</property>
-                                    <property name="yalign">0</property>
                                   </object>
                                   <packing>
                                     <property name="left_attach">1</property>
@@ -2438,7 +2438,7 @@ if you know what you are doing.</small></property>
                                                         <property name="visible">True</property>
                                                         <property name="can_focus">False</property>
                                                         <property name="halign">start</property>
-                                                        <property name="yalign">1</property>
+                                                        <property name="valign">end</property>
                                                         <property name="stock">gtk-dialog-warning</property>
                                                       </object>
                                                       <packing>
@@ -2453,11 +2453,11 @@ if you know what you are doing.</small></property>
                                                         <property name="visible">True</property>
                                                         <property name="can_focus">False</property>
                                                         <property name="halign">start</property>
+                                                        <property name="valign">end</property>
                                                         <property name="label" translatable="yes"><small>Selected CPU model does not support Hyper-Threading</small></property>
                                                         <property name="use_markup">True</property>
                                                         <property name="single_line_mode">True</property>
                                                         <property name="max_width_chars">32</property>
-                                                        <property name="yalign">1</property>
                                                       </object>
                                                       <packing>
                                                         <property name="expand">True</property>
@@ -3704,11 +3704,11 @@ if you know what you are doing.</small></property>
                                                         <property name="visible">True</property>
                                                         <property name="can_focus">False</property>
                                                         <property name="halign">end</property>
+                                                        <property name="valign">start</property>
                                                         <property name="ypad">4</property>
                                                         <property name="label" translatable="yes">Storage forma_t:</property>
                                                         <property name="use_underline">True</property>
                                                         <property name="mnemonic_widget">disk-format</property>
-                                                        <property name="yalign">0</property>
                                                       </object>
                                                       <packing>
                                                         <property name="left_attach">0</property>
diff --git a/ui/gfxdetails.ui b/ui/gfxdetails.ui
index 7ac4600..9f85c8a 100644
--- a/ui/gfxdetails.ui
+++ b/ui/gfxdetails.ui
@@ -31,7 +31,6 @@
             <property name="can_focus">True</property>
             <property name="receives_default">False</property>
             <property name="halign">start</property>
-            <property name="yalign">0.56999999284744263</property>
             <property name="draw_indicator">True</property>
             <signal name="toggled" handler="on_graphics_use_password" swapped="no"/>
             <child>
@@ -368,9 +367,9 @@
         <property name="visible">True</property>
         <property name="can_focus">False</property>
         <property name="halign">end</property>
+        <property name="valign">start</property>
         <property name="label" translatable="yes">Open_GL:</property>
         <property name="use_underline">True</property>
-        <property name="yalign">0</property>
       </object>
       <packing>
         <property name="left_attach">0</property>
diff --git a/ui/host.ui b/ui/host.ui
index 4aceb01..bb4651b 100644
--- a/ui/host.ui
+++ b/ui/host.ui
@@ -1423,8 +1423,8 @@
                                         <property name="visible">True</property>
                                         <property name="can_focus">False</property>
                                         <property name="halign">start</property>
+                                        <property name="valign">start</property>
                                         <property name="label" translatable="yes">MAC:</property>
-                                        <property name="yalign">0</property>
                                       </object>
                                       <packing>
                                         <property name="top_attach">1</property>
@@ -1438,9 +1438,9 @@
                                         <property name="visible">True</property>
                                         <property name="can_focus">False</property>
                                         <property name="halign">start</property>
+                                        <property name="valign">start</property>
                                         <property name="label">insert mac</property>
                                         <property name="selectable">True</property>
-                                        <property name="yalign">0</property>
                                       </object>
                                       <packing>
                                         <property name="left_attach">1</property>
@@ -1717,8 +1717,8 @@
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
                                             <property name="halign">start</property>
+                                            <property name="valign">start</property>
                                             <property name="label" translatable="yes">Address:</property>
-                                            <property name="yalign">0</property>
                                           </object>
                                           <packing>
                                             <property name="top_attach">1</property>
@@ -1732,9 +1732,9 @@
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
                                             <property name="halign">start</property>
+                                            <property name="valign">start</property>
                                             <property name="label">label</property>
                                             <property name="selectable">True</property>
-                                            <property name="yalign">0</property>
                                           </object>
                                           <packing>
                                             <property name="left_attach">1</property>
diff --git a/ui/migrate.ui b/ui/migrate.ui
index c65dbec..08a304b 100644
--- a/ui/migrate.ui
+++ b/ui/migrate.ui
@@ -339,7 +339,7 @@
                                           <object class="GtkImage" id="image2">
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
-                                            <property name="yalign">0</property>
+                                            <property name="valign">start</property>
                                             <property name="stock">gtk-dialog-warning</property>
                                           </object>
                                           <packing>
@@ -440,7 +440,7 @@ This can simplify setup since no additional firewall ports need to be open, and
                                           <object class="GtkImage" id="image3">
                                             <property name="visible">True</property>
                                             <property name="can_focus">False</property>
-                                            <property name="yalign">0</property>
+                                            <property name="valign">start</property>
                                             <property name="stock">gtk-dialog-warning</property>
                                           </object>
                                           <packing>
diff --git a/ui/netlist.ui b/ui/netlist.ui
index 84026df..ce5fa44 100644
--- a/ui/netlist.ui
+++ b/ui/netlist.ui
@@ -188,11 +188,11 @@
     <property name="visible">True</property>
     <property name="can_focus">False</property>
     <property name="halign">end</property>
+    <property name="valign">start</property>
     <property name="ypad">3</property>
     <property name="label" translatable="yes">_Network source:</property>
     <property name="use_underline">True</property>
     <property name="mnemonic_widget">net-source</property>
-    <property name="yalign">0</property>
   </object>
   <object class="GtkExpander" id="vport-expander">
     <property name="can_focus">True</property>
diff --git a/ui/snapshots.ui b/ui/snapshots.ui
index d3de6db..289f189 100644
--- a/ui/snapshots.ui
+++ b/ui/snapshots.ui
@@ -122,10 +122,10 @@
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
                     <property name="halign">start</property>
+                    <property name="valign">start</property>
                     <property name="label" translatable="yes">_Description:</property>
                     <property name="use_underline">True</property>
                     <property name="mnemonic_widget">snapshot-new-description</property>
-                    <property name="yalign">0</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
@@ -204,8 +204,8 @@
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
                     <property name="halign">start</property>
+                    <property name="valign">start</property>
                     <property name="label" translatable="yes">Screenshot:</property>
-                    <property name="yalign">0</property>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
@@ -357,8 +357,8 @@
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="halign">start</property>
+                                <property name="valign">start</property>
                                 <property name="label" translatable="yes">Description:</property>
-                                <property name="yalign">0</property>
                               </object>
                               <packing>
                                 <property name="left_attach">0</property>
@@ -501,8 +501,8 @@
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="halign">start</property>
+                                <property name="valign">start</property>
                                 <property name="label" translatable="yes">Screenshot:</property>
-                                <property name="yalign">0</property>
                               </object>
                               <packing>
                                 <property name="left_attach">0</property>
-- 
2.9.4




More information about the virt-tools-list mailing list