[virt-tools-list] [virt-manager PATCH] pycodestyle: fix all E125 warnings

Chen Hanxiao chen_han_xiao at 126.com
Sun Oct 22 11:30:04 UTC 2017

At 2017-10-22 00:18:49, "Cole Robinson" <crobinso at redhat.com> wrote:
>On 10/21/2017 02:30 AM, Chen Hanxiao wrote:
>> At 2017-10-02 17:58:58, "Pavel Hrdina" <phrdina at redhat.com> wrote:
>>> On Wed, Sep 20, 2017 at 04:06:49PM +0800, Chen Hanxiao wrote:
>>>> From: Chen Hanxiao <chenhanxiao at gmail.com>
>>>>          # Define the change
>>> This change will fix the E125 warning but it could be extended to fix
>>> the E128 warning as well.  Otherwise these lines would be modified twice
>>> in order to fix both warnings.  What I would suggest is to create a
>>> patch series, that fixes all of E126, E127, E128, E125, E129, E122 in
>>> that order.  These warnings are slightly related.
>> Sorry for the late reply.
>> As [1], this patch fix 4 E128 but introduce a new one.
>> We had too many E128 warnings : <
>> When I had time, I'll create a series with the order as your suggestion.
>> With Cole's ACK, I'll push this patch later.
>Whoops, I missed pavel's comments, I didn't intend to override them with
>my ACK, I thought the patch hadn't been reviewed. I agree with his
>comments though so a complete series to clean the similar issues up will
>be nice

I agree Pavel's comments too.
But there're toooo many E128 warnings....
Maybe I could try that series next holiday.

I'll be more careful next time before pushing.

- Chen

More information about the virt-tools-list mailing list