[virt-tools-list] [virt-manager PATCH 3/4] graphics: introduce listens.socket parameter

Pavel Hrdina phrdina at redhat.com
Wed Sep 6 08:36:00 UTC 2017


Add support to configure socket path for socket listen type.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 tests/cli-test-xml/compare/virt-install-many-devices.xml | 4 ++++
 tests/clitest.py                                         | 1 +
 virtinst/cli.py                                          | 2 ++
 virtinst/devicegraphics.py                               | 1 +
 4 files changed, 8 insertions(+)

diff --git a/tests/cli-test-xml/compare/virt-install-many-devices.xml b/tests/cli-test-xml/compare/virt-install-many-devices.xml
index 48b215cf..655138e0 100644
--- a/tests/cli-test-xml/compare/virt-install-many-devices.xml
+++ b/tests/cli-test-xml/compare/virt-install-many-devices.xml
@@ -257,6 +257,10 @@
       <image compression="off"/>
       <listen type="network" network="default"/>
     </graphics>
+    <graphics type="spice">
+      <image compression="off"/>
+      <listen type="socket" socket="/tmp/foobar"/>
+    </graphics>
     <serial type="tcp">
       <source mode="bind" host="127.0.0.1" service="2222"/>
       <protocol type="telnet"/>
diff --git a/tests/clitest.py b/tests/clitest.py
index 2373b461..49753590 100644
--- a/tests/clitest.py
+++ b/tests/clitest.py
@@ -488,6 +488,7 @@ c.add_compare(""" \
 --graphics spice,gl=yes,listen=none,rendernode=/dev/dri/foo \
 --graphics spice,listens0.type=address,listens0.address=1.2.3.4 \
 --graphics spice,listens0.type=network,listens0.network=default \
+--graphics spice,listens0.type=socket,listens0.socket=/tmp/foobar \
 \
 --controller usb,model=ich9-ehci1,address=0:0:4.7,index=0 \
 --controller usb,model=ich9-uhci1,address=0:0:4.0,index=0,master=0 \
diff --git a/virtinst/cli.py b/virtinst/cli.py
index 9f5fd214..05cbc739 100644
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -2283,6 +2283,8 @@ ParserGraphics.add_arg("address", "listens[0-9]*.address",
                        find_inst_cb=ParserGraphics.listens_find_inst_cb)
 ParserGraphics.add_arg("network", "listens[0-9]*.network",
                        find_inst_cb=ParserGraphics.listens_find_inst_cb)
+ParserGraphics.add_arg("socket", "listens[0-9]*.socket",
+                       find_inst_cb=ParserGraphics.listens_find_inst_cb)
 ParserGraphics.add_arg(None, "keymap", cb=ParserGraphics.set_keymap_cb)
 ParserGraphics.add_arg("passwd", "password")
 ParserGraphics.add_arg("passwdValidTo", "passwordvalidto")
diff --git a/virtinst/devicegraphics.py b/virtinst/devicegraphics.py
index d7f04535..dc6919e9 100644
--- a/virtinst/devicegraphics.py
+++ b/virtinst/devicegraphics.py
@@ -45,6 +45,7 @@ class _GraphicsListen(XMLBuilder):
     type = XMLProperty("./@type")
     address = XMLProperty("./@address")
     network = XMLProperty("./@network")
+    socket = XMLProperty("./@socket")
 
 
 class VirtualGraphics(VirtualDevice):
-- 
2.13.5




More information about the virt-tools-list mailing list