[virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console &basic VM state

[Marc-André Lureau]

Hi Xiaodai

On Thu, Aug 2, 2018 at 10:56 AM, Xiaodai Wang <xiaodwan at redhat.com> wrote:
>
> ----- Original Message -----
>> From: "Marc-André Lureau" <marcandre.lureau at redhat.com>
>> To: "Xiaodai Wang" <xiaodwan at redhat.com>
>> Cc: "virt-tools-list" <virt-tools-list at redhat.com>
>> Sent: Wednesday, August 1, 2018 9:46:47 PM
>> Subject: Re: [virt-tools-list] [PATCH 00/22] Add QEMU-like UI: VT console &basic VM state
>>
>> Hi
>>
>> On Wed, Aug 1, 2018 at 1:50 PM, Xiaodai Wang <xiaodwan at redhat.com> wrote:
>> > Sorry, i didn't receive the email of "patch 10/22", but i can find it in
>> > virt-tools-list.
>> > I just Added my comments here.
>> >
>> > 1)
>> > +    vte = gtk_label_new(_("Console support is compiled out!"));
>> >
>> > I think the hints could be changed to be more general for all users. It may
>> > be hard to understand
>> > for users who don't know programming.
>>
>> What do you recommend instead?
>>
>   If vte is compiled out, it's better to hide or grey out the menu item and give a warning or debug
> message to show why it's not supported.

I think this is less user friendly though, the user won't notice a
debug log (it might not even be enabled), and a warning is assimilated
to a user or program error, in general.

Tbh, I would rather make VTE a strong dependency.

>
>
> I did not receive this mail '[virt-tools-list] [PATCH 20/22] app: add "machine" UI', either.
> Here is my other comments.
>
> 1. Since virt-viewer have -w and -r options which can wait for a vm to startup, It's better to add a 'Run' menu to start the VM.

the "machine" menu is only for remote-viewer. Furthermore, my goal is
not to make a new virt-manager, it's really just to have a simple UI
like qemu gtk does, so eventually, qemu console user  (mostly
developpers) can switch to it easily.

> 2. The 'Pause' menu item should be changed to 'Resume' after pausing the VM, and changed to 'pause' again after running.

Again, I am just following the current qemu UI, but eventually we
could try to do better.

>
> 3. +                    <property name="label" translatable="yes">_Machine</property>
>    I prefer 'Virtual Machine' to 'Machine'. It's same as virt-manager.
>
> 4. <property name="label" translatable="yes">_Reset</property>
>    Does 'Reset' means 'Reboot'?
>
>    <property name="label" translatable="yes">_Power down</property>
>    Does 'Power down' means 'Shut Down'?
>

Same here.

Tbh, I think the "File" menu could be merged. and we could adopt some
GNOME3 style icon menu


>    I think the menu item name should be same as other products of redhat, like virt-manager, ovirt.

Or be the same as qemu, if your goal is to replace qemu ui :)