[virt-tools-list] [PATCH 0/2] Fixes for some hotkey issues in virt-viewer/remote-viewer

[Paul Donohue]

gtk_accel_map_change_entry() seems to reject lots of hotkey 
combinations, and virt-viewer silently ignores these rejections.  This 
is very confusing for a user whose hotkeys simply aren't working.  The 
first patch causes a message to be printed if 
gtk_accel_map_change_entry() fails, so the user can at least identify 
why the hotkeys aren't working.

The second patch re-works the handling of the release-cursor hotkey to:
1) Use spice_display_set_grab_keys() or vnc_display_set_grab_keys() 
   instead of gtk_accel_map_change_entry() to configure the hotkey, 
   which greatly increases the number of hotkey sequences that can be 
   used.  (For example, gtk_accel_map_change_entry() prohibits Ctrl+Alt 
   while spice_display_set_grab_keys() and vnc_display_set_grab_keys() 
   allow that sequence.)
2) Avoid the use of spice_display_mouse_ungrab(), which doesn't properly 
   release the keyboard grab.  (See 
   https://gitlab.freedesktop.org/spice/spice-gtk/issues/73 )

Paul Donohue (2):
  Report gtk_accel_map_change_entry() failures
  Handle release-cursor hotkey in VNC/Spice instead of GTK

 src/virt-viewer-app.c           |  65 ++++++++++++----
 src/virt-viewer-app.h           |   2 +
 src/virt-viewer-display-spice.c |  16 ++--
 src/virt-viewer-display-vnc.c   |  16 ++--
 src/virt-viewer-file.c          |   7 +-
 src/virt-viewer-util.c          | 127 ++++++++++++++++++++++++++++++++
 src/virt-viewer-util.h          |   1 +
 src/virt-viewer-window.c        |  17 +----
 8 files changed, 210 insertions(+), 41 deletions(-)

-- 
2.17.1