[virt-tools-list] [PATCH 3/3] virt-manager: Add support for vsock devices to add hardware UI

Pavel Hrdina phrdina at redhat.com
Mon Dec 10 06:06:21 UTC 2018

On Fri, Dec 07, 2018 at 05:02:16PM +0200, Slavomir Kaslev wrote:
> Signed-off-by: Slavomir Kaslev <kaslevs at vmware.com>
> ---
>  ui/addhardware.ui          | 94 ++++++++++++++++++++++++++++++++++++++
>  virtManager/addhardware.py | 33 ++++++++++++-
>  2 files changed, 125 insertions(+), 2 deletions(-)

This patch looks like a lot of code duplication, so I would suggest to
create vsockdetails.py or or similar name and follow the same logic as
for gfxdetails.py and gfxdetails.ui where the files are shared for
details window and addhardware window.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20181210/bc99f897/attachment.sig>

More information about the virt-tools-list mailing list