[virt-tools-list] [PATCH v2 6/6] details: show TPM device model and allow updating it

Stefan Berger stefanb at linux.vnet.ibm.com
Mon Jun 11 16:00:37 UTC 2018

On 06/11/2018 11:54 AM, Cole Robinson wrote:
> On 06/08/2018 05:42 PM, Stefan Berger wrote:
>> Show the TPM device model and allow updating it. If a TPM 1.2 has been
>> chosen, we only allow the TIS interface to be selected. In case of a
>> TPM 2.0 we also enable the choice of the CRB interface.
> Patches look good, thanks. One question here though: is this something
> we actually expect end users to change for an existing VM? What's the

One use case would be related to an OS (like Win) not liking the TIS 
interface for some reason with a TPM 2 but it wants the CRB instead. 
It's a real-world use case.

Otherwise I added it because I wanted to see what interface had been 
defined and had a read-only interface first. Then I saw what the 
networking page etc. offered and thought I'd do the same rather than 
having to force a user to remove the device and add it with a different 

> usecase, besides testing for virt stack developers? I'm trying to be
> more discerning of the types of things we allow tweaking in the details
> page since it can turn into a bit of a slippery slope, requires more UI
> testing and maintenance, etc

> Thanks,
> Cole

More information about the virt-tools-list mailing list