[virt-tools-list] [virt-manager PATCH] Allow installation of i686 guests on x86_64 machines

Martin Kletzander mkletzan at redhat.com
Thu Mar 1 08:52:16 UTC 2018


Do that by changing the code that was disabling it into code that just warns in
such case.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 virtManager/create.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/virtManager/create.py b/virtManager/create.py
index 0a73309372d9..9a40aec4a068 100644
--- a/virtManager/create.py
+++ b/virtManager/create.py
@@ -495,6 +495,10 @@ class vmmCreate(vmmGObjectUI):
                 msg = _("Failed to setup UEFI for AArch64: %s\n"
                         "Install options are limited.") % e
                 self._show_arch_warning(msg)
+        elif (self._capsinfo.arch == "i686" and
+              self.conn.caps.host.cpu.arch == "x86_64"):
+            msg = _("You are installing 32bit guest on 64bit host")
+            self._show_arch_warning(msg)
 
         # Install Options
         method_tree = self.widget("method-tree")
@@ -824,12 +828,6 @@ class vmmCreate(vmmGObjectUI):
             if guest.os_type == self._capsinfo.os_type:
                 archs.append(guest.arch)
 
-        # Combine x86/i686 to avoid confusion
-        if (self.conn.caps.host.cpu.arch == "x86_64" and
-            "x86_64" in archs and "i686" in archs):
-            archs.remove("i686")
-        archs.sort()
-
         prios = ["x86_64", "i686", "aarch64", "armv7l", "ppc64", "ppc64le",
             "s390x"]
         if self.conn.caps.host.cpu.arch not in prios:
-- 
2.16.2




More information about the virt-tools-list mailing list