[virt-tools-list] [virt-manager] [PATCH 0/5] Use pylint/pycodestyle modules

[Radostin Stoyanov]

On 03/03/18 21:09, Cole Robinson wrote:
> On 03/02/2018 03:01 AM, Radostin Stoyanov wrote:
>> Radostin Stoyanov (5):
>>   pylint: Use pylint.lint module
>>   pylint: Silence inconsistent-return-statements
>>   pylint: Resolve logging-not-lazy
>>   pylint: Resolve consider-using-enumerate
>>   pycodestyle: Use module instead of executable
>>
>>  setup.py                    | 33 ++++++++++++++++++++-------------
>>  tests/clitest.py            |  2 +-
>>  tests/pylint.cfg            |  2 +-
>>  virtManager/addhardware.py  |  4 ++--
>>  virtManager/clone.py        |  2 +-
>>  virtManager/connectauth.py  |  2 +-
>>  virtManager/connection.py   |  4 ++--
>>  virtManager/graphwidgets.py | 20 +++++++-------------
>>  virtinst/installer.py       |  2 +-
>>  virtinst/interface.py       |  4 ++--
>>  virtinst/storage.py         |  4 ++--
>>  virtinst/urlfetcher.py      |  6 +++---
>>  12 files changed, 43 insertions(+), 42 deletions(-)
>>
> ACK and pushed, thanks! How many hits does
> inconsistent-return-statements trigger? I'd take a patch to fix that
Not that many, there are about 90 inconsistent-return-statements.
However most of them are incorrect.
Currently there are some cases that are not recognised by pylint. (See
https://github.com/PyCQA/pylint/issues/1782 and
https://github.com/home-assistant/home-assistant/pull/12274).
Lets wait for this bug to be fixed before modifying virt-manager's code.

Radostin
> Thanks,
> Cole