[virt-tools-list] [libvirt] [PATCH 06/22] esx_vi_generator: Simplify generate_helper_header

Radostin Stoyanov rstoyanov1 at gmail.com
Sat Mar 17 13:48:42 UTC 2018


The function generate_helper_header() only returns a formatted string.
This could be achieved without performing string concatenation.

Signed-off-by: Radostin Stoyanov <rstoyanov1 at gmail.com>
---
 src/esx/esx_vi_generator.py | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py
index 19c225384..1641a2a1e 100755
--- a/src/esx/esx_vi_generator.py
+++ b/src/esx/esx_vi_generator.py
@@ -1021,20 +1021,15 @@ class ManagedObject(GenericObject):
 
 
     def generate_helper_header(self):
-        header = ""
-
         # functions
-        header += ("int esxVI_Lookup%s(esxVI_Context *ctx, "
-                                      "const char *name, "
-                                      "esxVI_ManagedObjectReference *root, "
-                                      "esxVI_String *selectedPropertyNameList, "
-                                      "esxVI_%s **item, "
-                                      "esxVI_Occurrence occurrence);\n") \
-                  % (self.name, self.name)
-
-        header += "\n"
-
-        return header
+        return (
+            "int esxVI_Lookup{name}(esxVI_Context *ctx, "
+                                   "const char *name, "
+                                   "esxVI_ManagedObjectReference *root, "
+                                   "esxVI_String *selectedPropertyNameList, "
+                                   "esxVI_{name} **item, "
+                                   "esxVI_Occurrence occurrence);\n\n"
+        ).format(name=self.name)
 
 
     def generate_source(self):
-- 
2.14.3




More information about the virt-tools-list mailing list