[virt-tools-list] [virt-manager PATCH 1/5] virt-install: Fix description for --os-variant

Pavel Hrdina phrdina at redhat.com
Mon Nov 12 15:21:01 UTC 2018


On Mon, Nov 12, 2018 at 04:07:06PM +0100, Andrea Bolognani wrote:
> On Mon, 2018-11-12 at 15:35 +0100, Pavel Hrdina wrote:
> > On Fri, Nov 09, 2018 at 04:36:36PM +0100, Andrea Bolognani wrote:
> > > Since we're messing with it either way, might as well use
> > > modern OS names as examples.
> > 
> > I would not use "fix" in the subject.  There is nothing wrong, it's
> > just outdated, improve or something else would be better.
> 
> The fix part is in the first line, "The OS variant being installed
> guests" -> "The OS variant being installed in the guest".
> 
> I can split the second part (listing more modern OS) into a separate
> patch if you prefer, I just didn't feel like it would necessarily be
> worth it :)

Right :) I completely missed that change, in that case it makes more
sense, there is no need to change it.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20181112/ec1158a1/attachment.sig>


More information about the virt-tools-list mailing list