[virt-tools-list] [PATCH 00/10] Improve and fix UI tests

[Cole Robinson]

On 09/01/2018 06:15 PM, Povilas Kanapickas wrote:
> The following patch series fixes a bunch of small issues in UI tests
> that made them a little more brittle than needed or possibly outright
> broken. I'm a new contributor, likely missed something and my
> environment is probably different than what the maintainers use so
> at least several of the failures that I saw were caused by these
> reasons. My  environment is Ubuntu 18.04 with KDE and distribution
> version of libvirt (4.0.0; virt-manager is newest git). Having said
> that, the patches still fix 8 broken testCases:
>   - testAddControllers
>   - testAddDisks
>   - testAddGraphics
>   - testAddNetworks
>   - testChooseCDHotplug
>   - testDetailsEdits
>   - testManagerWindowCleanup
>   - testPrefs
> 
> Regards,
> Povilas
> 
> 
> Povilas Kanapickas (10):
>    uitests: Improve error message caused by another virt-manager being
>      open
>    uitests: Don't fail when requiested file is not visible
>    uitests: Don't fail when running on older libvirt versions
>    uitests: Improve robustness of click_combo_entry()
>    choosecd: Emit cdrom-chosen signal after the dialog has been closed
>    details: Pin network-model label directly to combo to simplify tests
>    uitests: Fix onscreen to return True only when full widget is on
>      screen
>    uitests: Fix selection of items in long menus that don't fit on screen
>    uitests: Increase click offset for window drag
>    uitests: Use Ctrl_L+Alt_L+Z as a grab keys when testing prefs
> 
>   tests/uitests/addhardware.py | 21 +++++++++++++++++-
>   tests/uitests/details.py     | 16 ++++++++------
>   tests/uitests/manager.py     |  2 +-
>   tests/uitests/prefs.py       |  5 +++++
>   tests/uitests/utils.py       | 42 ++++++++++++++++++++++++++++++------
>   ui/details.ui                |  4 ++--
>   virtManager/choosecd.py      |  2 +-
>   7 files changed, 75 insertions(+), 17 deletions(-)
> 

Aside from patch #1 and #3 which I commented on, I pushed the rest. Thanks!

- Cole

- Cole