[virt-tools-list] [virt-manager PATCH 0/2] show ip in details page of domain interface

Cole Robinson crobinso at redhat.com
Wed Sep 5 19:13:51 UTC 2018

On 08/31/2018 06:37 AM, Lin Ma wrote:
> Uses lease, agent and arp to try to get ipv4 and ipv6 address of given interface
> Lin Ma (2):
>    domain: Add function interface_addresses to return ipv4 and ipv6
>    details: Show ipv4 and ipv6 address in details page of interface
>   ui/details.ui          | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++
>   virtManager/details.py | 59 +++++++++++++++++++++++++++++++++++++
>   virtManager/domain.py  | 27 +++++++++++++++++
>   3 files changed, 165 insertions(+)

Thanks for these! I've pushed them now. I added a commit on top that 
aimed to improve a few things: tweak the UI, handle errors, cache 
results better, and open it up to work on more hypervisor drivers. 
Please give it a try and make sure it still meets your usecases:

commit b4b7c7b5203dac9c5583b130bb8808d7a0b528fd (HEAD -> ip)
Author: Cole Robinson <crobinso at redhat.com>
Date:   Tue Sep 4 19:02:40 2018 -0400

     details: IP address fixes/improvements

     * Tweak the UI
     * Add accelerator for the refresh button
     * Make the IP labels selectable
     * Drop the IP prefix from the UI, it's not the important bit
     * Call DHCPLeases on the network instead to support this for more
       drivers, like LXC
     * Cache the IP results in the domain/network object wrappers
     * Catch and log errors
     * Poll for IP address when first visiting the interface page


More information about the virt-tools-list mailing list