[virt-tools-list] [virt-manager] [PATCH 2/4] details: Add VM genid support

Cole Robinson crobinso at redhat.com
Mon Apr 1 17:54:08 UTC 2019


On 3/26/19 5:42 AM, Lin Ma wrote:
> Currently, It doesn't support manually specify the genid value in the
> details window, Only supports auto value.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>  ui/details.ui          | 38 ++++++++++++++++++++++++++++++++------
>  virtManager/details.py | 17 ++++++++++++++++-
>  virtManager/domain.py  |  7 ++++++-
>  3 files changed, 54 insertions(+), 8 deletions(-)
> 

Sorry but I don't think this belongs in the UI. It's a pretty niche
feature AFAICT. Even making it readonly in the UI isn't really
interesting, the UUID value doesn't have any real value for reading.
Enabling this feature also blocks some libvirt behavior like reverting a
live VM to a live snapshot, so it's kind of problematic for desktop type
usescases.

- Cole




More information about the virt-tools-list mailing list