[virt-tools-list] [virt-viewer PATCH] ovirt-foreign-menu: Fix warnings on Rawhide

Fabiano Fidêncio fidencio at redhat.com
Thu Aug 15 15:07:06 UTC 2019


gmaovirt-foreign-menu.c: In function 'storage_domains_fetched_cb':
ovirt-foreign-menu.c:721:9: error: format not a string literal and no format arguments [-Werror=format-security]
  721 |         g_debug(msg);
      |         ^~~~~~~
ovirt-foreign-menu.c:722:9: error: format not a string literal and no format arguments [-Werror=format-security]
  722 |         g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
      |         ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
gmake[3]: *** [Makefile:963: libvirt_viewer_la-ovirt-foreign-menu.lo] Error 1
gmake[2]: *** [Makefile:647: all] Error 2
gmake[1]: *** [Makefile:482: all-recursive] Error 1
make: *** [Makefile:410: all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.f14Lmj (%build)

Errors have been caught by https://ci.centos.org/job/virt-viewer-rpm/systems=libvirt-fedora-rawhide/589/

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
---
 src/ovirt-foreign-menu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ovirt-foreign-menu.c b/src/ovirt-foreign-menu.c
index 75f9ac4..4ec0858 100644
--- a/src/ovirt-foreign-menu.c
+++ b/src/ovirt-foreign-menu.c
@@ -718,8 +718,8 @@ static void storage_domains_fetched_cb(GObject *source_object,
         const char *msg = domain_valid ? "Could not find ISO file collection"
                                        : "Could not find valid ISO storage domain";
 
-        g_debug(msg);
-        g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, msg);
+        g_debug("%s", msg);
+        g_task_return_new_error(task, OVIRT_ERROR, OVIRT_ERROR_FAILED, "%s", msg);
         g_object_unref(task);
     }
 }
-- 
2.21.0




More information about the virt-tools-list mailing list