[virt-tools-list] [PATCH] virtinst: add KVM feature kvm_hint_dedicated

Cole Robinson crobinso at redhat.com
Mon Aug 19 20:35:14 UTC 2019


On 8/13/19 2:57 AM, Menno Lageman wrote:
> QEMU version 2.12.1 introduced a performance feature under commit
> be7773268d98 ("target-i386: add KVM_HINTS_DEDICATED performance hint").
> Support for this performance hint was added in libvirt 5.7.0 by commit
> cb12c59dac04 ("qemu: support for kvm-hint-dedicated performance hint").
> 
> This patch extends virt-install's existing --features option to insert the
> appropriate XML into the guest definition if this feature is specified
> on the command line.
> 
>     E.g. --features='kvm_hint_dedicated=on' would result
>     in the following XML:
> 
>       <features>
>         ...
>         <kvm>
>           <hint-dedicated state='on'/>
>         </kvm>
>         ...
>       </features>
> 
> Signed-off-by: Menno Lageman <menno.lageman at oracle.com>

Patch looks good! I will wait for libvirt 5.7.0 to be released, then
I'll apply this and respond here

Thanks,
Cole




More information about the virt-tools-list mailing list