[virt-tools-list] [virt-manager RFC PATCH 2/2] details: snapshots: Warn of saved state on creation

[Cole Robinson]

On 12/19/19 4:52 PM, Michael Weiser wrote:
> Add a confirmation dialog when creating a new snapshot if there is saved
> memory state so the user is aware that memory state will not be part of
> the snapshot.
> 
> Signed-off-by: Michael Weiser <michael.weiser at gmx.de>
> Suggested-by: Cole Robinson <crobinso at redhat.com>
> ---
>  virtManager/details/snapshots.py | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/virtManager/details/snapshots.py b/virtManager/details/snapshots.py
> index bc5b915a..c2aecd93 100644
> --- a/virtManager/details/snapshots.py
> +++ b/virtManager/details/snapshots.py
> @@ -633,6 +633,17 @@ class vmmSnapshotPage(vmmGObjectUI):
>              self._snapshot_new = vmmSnapshotNew(self.vm)
>              self._snapshot_new.connect("snapshot-created",
>                      self._snapshot_created_cb)
> +        if self.vm.has_managed_save():
> +            result = self.err.ok_cancel(
> +                _("Saved memory state will not be part of the snapshot"),
> +                _("The domain is currently saved. Due to technical "
> +                  "limitations that saved memory state will not become part "
> +                  "of the snapshot. Running it later will be the same as "
> +                  "having forced the system off mid-flight. It is "
> +                  "recommended to snapshot either the running or shut down "
> +                  "system instead."))
> +            if not result:
> +                return
>          self._snapshot_new.show(self.topwin)
>  
>      def _on_refresh_clicked(self, ignore):
> 

These 2 look good to me, I've pushed them now

Thanks,
Cole