[virt-tools-list] [PATCH virt-manager 03/10] domain: Try to avoid self access since we're operating on guest

Marc Hartmayer mhartmay at linux.ibm.com
Wed Feb 6 09:55:36 UTC 2019

Try to avoid self access since this function operates on the guest
definition only. This is needed for later refactoring as it will
reduce side-effects.

Signed-off-by: Marc Hartmayer <mhartmay at linux.ibm.com>
Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>
 virtManager/domain.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/virtManager/domain.py b/virtManager/domain.py
index 14237eb4432a..f43439c518c5 100644
--- a/virtManager/domain.py
+++ b/virtManager/domain.py
@@ -524,7 +524,7 @@ class vmmDomain(vmmLibvirtObject):
     def __use_device_boot_order(self, boot_order, guest):
         boot_dev_order = []
         devmap = dict((dev.get_xml_id(), dev) for dev in
-                      self.get_bootable_devices())
+                      guest.get_bootable_devices(exclude_redirdev=True))
         for b in boot_order:
             if b in devmap:

More information about the virt-tools-list mailing list