[virt-tools-list] [PATCH virt-install 0/4] Add install parameter to the --os-variant

Daniel P. Berrangé berrange at redhat.com
Mon Feb 11 10:16:26 UTC 2019


On Fri, Feb 08, 2019 at 04:23:54PM +0100, Fabiano Fidêncio wrote:
> This series introduces a new option to virt-install:
> virt-install --name GuestName --os-variant fedora29,install=location
>                                                     ----------------
>                                                           |
>                                                           v
>                                                      The new bit!

We already have a "--location" arg that gives an installation tree
location, and a --cdrom arg that gives an ISO image local path (historically
it would allow a URI too IIRC).

I'm wondering if there's a need to combine all these different ways to
specifying the install tree/media location into a more general purpose
arg

> 
> When passing "install" parameter to --os-variant, virt-install will try
> to get the URL location from libosinfo, according to the OS variant.
> 
> The naming "location|cdrom" have been chosen as it's already what's been
> used by virt-install.
> 
> For now, install=location is the only thing implemented while
> install=cdrom is just a no-op.
> 
> Fabiano Fidêncio (4):
>   virt-install: Set options.disk if the value comes from osinfo-db
>   osdict: add get_location()
>   cli: Add "install" parameter to os-variant
>   virt-install: Deal with os-variant's install param
> 
>  virt-install       | 14 ++++++++++++++
>  virtinst/cli.py    |  2 ++
>  virtinst/osdict.py | 25 +++++++++++++++++++++++++
>  3 files changed, 41 insertions(+)
> 
> -- 
> 2.20.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the virt-tools-list mailing list