[virt-tools-list] [virt-manager PATCH] graphics: move all listen code into one place

Cole Robinson crobinso at redhat.com
Wed Feb 27 19:58:10 UTC 2019


On 2/22/19 10:44 AM, Pavel Hrdina wrote:
> Instead of duplicating the code into CLI and GUI move it into graphics
> device file which is used from both places.  This also fixes a bug in
> virt-xml where changing listen to address was not working.
> 
> This also changes behavior to always configure one listen type when
> using CLI listen option or GUI.  If user wants to modify only specific
> listen type they can use listens[] options from CLI.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1565968
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  tests/xmlparse-xml/change-graphics-out.xml |  1 -
>  virtManager/addhardware.py                 |  2 +-
>  virtManager/domain.py                      | 13 +++++-------
>  virtinst/cli.py                            | 12 +----------
>  virtinst/devices/graphics.py               | 24 +++++++++++-----------
>  5 files changed, 19 insertions(+), 33 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso at redhat.com>

- Cole




More information about the virt-tools-list mailing list