[virt-tools-list] [virt-manager] [PATCH 2/2] cli: Register parser for ParseCLICheck

[Cole Robinson]

On 12/24/2018 03:35 AM, Lin Ma wrote:
> The completion of --check subprops needs it work.
> 
> Signed-off-by: Lin Ma <lma at suse.com>
> ---
>   virtinst/cli.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/virtinst/cli.py b/virtinst/cli.py
> index 3ba81861..2996dbc3 100644
> --- a/virtinst/cli.py
> +++ b/virtinst/cli.py
> @@ -1321,6 +1321,7 @@ class ParseCLICheck(VirtCLIParser):
>           inst.set_validation_check(virtarg.cliname, val)
>   
>   
> +_register_virt_parser(ParseCLICheck)
>   ParseCLICheck.add_arg(None, "path_in_use", is_onoff=True,
>                         cb=ParseCLICheck.set_cb)
>   ParseCLICheck.add_arg(None, "disk_size", is_onoff=True,
> 

I didn't look into it deeply but this has some weird side effects, like 
I think --check will also set values on a Guest object from virt-install 
which might not cause any issues but it isn't good. I pushed a commit 
that instead factors in ParseCLICheck more directly in the completer 
functions, so this is fixed in git now

Thanks,
Cole