[virt-tools-list] [PATCH virt-viewer] Spice: listen for new 'SpiceSession::disconnected' signal

[Daniel P. Berrangé]

On Thu, Jan 17, 2019 at 12:06:42AM +0400, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Jan 4, 2019 at 11:08 PM Marc-André Lureau
> <marcandre.lureau at gmail.com> wrote:
> >
> > Hi
> >
> > On Tue, Sep 18, 2018 at 8:25 PM Jonathon Jongsma <jjongsma at redhat.com> wrote:
> > >
> > > Previously we were emitting the VirtViewerSession::session-disconnected
> > > when we got the Spice::session::channel-destroy signal for the last
> > > channel. However, since the channels are still valid at this point, and
> > > because VirtViewerApp quits the application in response to the
> > > session-disconnected signal, that means that the channels were never
> > > being properly freed. This was particularly problematic for the usbredir
> > > channel, which must disconnect any connected USB devices as part of its
> > > destruction. By using the new SpiceSession::disconnected signal instead,
> > > we can ensure that all channels have been disconnected and properly
> > > destroyed before quitting the application.
> > > ---
> > >
> > > NOTE: this is an older patch fell through the cracks. I added the
> > > SpiceSession::disconnected signal a while ago and was waiting for an
> > > official spice-gtk release before adding this patch to virt-viewer. The
> > > new spice-gtk release has been out for a while, but this patch was
> > > forgotten until now.
> > >
> > >  src/virt-viewer-session-spice.c | 24 +++++++++++++++++++-----
> > >  1 file changed, 19 insertions(+), 5 deletions(-)
> >
> > This patch introduces a regression, virt-viewer now hangs when the
> > initial connection fails.
> > Reverting the patch works again
> >
> > Jonathon, can you take a look?
> 
> To not loose track of this regression, I opened
> https://bugzilla.redhat.com/show_bug.cgi?id=1666869
> 
> Daniel, Bugzilla is not that great to track upstream issues. Would
> pagure issues be better?

Bugzilla works just fine. I have much more confidence in bugzilla
staying alive than Pagure which is developed & maintained by just
a handful of people. Prior experiance with fedorahosted.org doesn't
give me confidence in pagure's long term prospects since no one
else is using it.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|